[mlir][Transforms] More detailed error message when new IR cannot be legalized #152297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-springer
requested review from
zero9178 and
j2kun
and removed request for
zero9178
|
@llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesPrint a more detailed error message when new/modified IR could not be legalized with Full diff: https://github.com/llvm/llvm-project/pull/152297.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index f23c6197accd5..463394c19b51c 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2302,6 +2302,37 @@ OperationLegalizer::legalizeWithFold(Operation *op,
return success();
}
+/// Report a fatal error indicating that newly produced or modified IR could
+/// not be legalized.
+static void
+reportNewIrLegalizationFatalError(const Pattern &pattern,
+ const SetVector<Operation *> &newOps,
+ const SetVector<Operation *> &modifiedOps,
+ const SetVector<Block *> &insertedBlocks) {
+ StringRef detachedBlockStr = "(detached block)";
+ std::string newOpNames = llvm::join(
+ llvm::map_range(
+ newOps, [](Operation *op) { return op->getName().getStringRef(); }),
+ ", ");
+ std::string modifiedOpNames = llvm::join(
+ llvm::map_range(
+ newOps, [](Operation *op) { return op->getName().getStringRef(); }),
+ ", ");
+ std::string insertedBlockNames = llvm::join(
+ llvm::map_range(insertedBlocks,
+ [&](Block *block) {
+ if (block->getParentOp())
+ return block->getParentOp()->getName().getStringRef();
+ return detachedBlockStr;
+ }),
+ ", ");
+ llvm::report_fatal_error(
+ "pattern '" + pattern.getDebugName() +
+ "' produced IR that could not be legalized. " + "new ops: {" +
+ newOpNames + "}, " + "modified ops: {" + modifiedOpNames + "}, " +
+ "inserted block into ops: {" + insertedBlockNames + "}");
+}
+
LogicalResult
OperationLegalizer::legalizeWithPattern(Operation *op,
ConversionPatternRewriter &rewriter) {
@@ -2389,8 +2420,8 @@ OperationLegalizer::legalizeWithPattern(Operation *op,
appliedPatterns.erase(&pattern);
if (failed(result)) {
if (!rewriterImpl.config.allowPatternRollback)
- llvm::report_fatal_error("pattern '" + pattern.getDebugName() +
- "' produced IR that could not be legalized");
+ reportNewIrLegalizationFatalError(pattern, newOps, modifiedOps,
+ insertedBlocks);
rewriterImpl.resetState(curState, pattern.getDebugName());
}
if (config.listener)
|
|
@llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) ChangesPrint a more detailed error message when new/modified IR could not be legalized with Full diff: https://github.com/llvm/llvm-project/pull/152297.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index f23c6197accd5..463394c19b51c 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2302,6 +2302,37 @@ OperationLegalizer::legalizeWithFold(Operation *op,
return success();
}
+/// Report a fatal error indicating that newly produced or modified IR could
+/// not be legalized.
+static void
+reportNewIrLegalizationFatalError(const Pattern &pattern,
+ const SetVector<Operation *> &newOps,
+ const SetVector<Operation *> &modifiedOps,
+ const SetVector<Block *> &insertedBlocks) {
+ StringRef detachedBlockStr = "(detached block)";
+ std::string newOpNames = llvm::join(
+ llvm::map_range(
+ newOps, [](Operation *op) { return op->getName().getStringRef(); }),
+ ", ");
+ std::string modifiedOpNames = llvm::join(
+ llvm::map_range(
+ newOps, [](Operation *op) { return op->getName().getStringRef(); }),
+ ", ");
+ std::string insertedBlockNames = llvm::join(
+ llvm::map_range(insertedBlocks,
+ [&](Block *block) {
+ if (block->getParentOp())
+ return block->getParentOp()->getName().getStringRef();
+ return detachedBlockStr;
+ }),
+ ", ");
+ llvm::report_fatal_error(
+ "pattern '" + pattern.getDebugName() +
+ "' produced IR that could not be legalized. " + "new ops: {" +
+ newOpNames + "}, " + "modified ops: {" + modifiedOpNames + "}, " +
+ "inserted block into ops: {" + insertedBlockNames + "}");
+}
+
LogicalResult
OperationLegalizer::legalizeWithPattern(Operation *op,
ConversionPatternRewriter &rewriter) {
@@ -2389,8 +2420,8 @@ OperationLegalizer::legalizeWithPattern(Operation *op,
appliedPatterns.erase(&pattern);
if (failed(result)) {
if (!rewriterImpl.config.allowPatternRollback)
- llvm::report_fatal_error("pattern '" + pattern.getDebugName() +
- "' produced IR that could not be legalized");
+ reportNewIrLegalizationFatalError(pattern, newOps, modifiedOps,
+ insertedBlocks);
rewriterImpl.resetState(curState, pattern.getDebugName());
}
if (config.listener)
|
Co-authored-by: Jeremy Kun <[email protected]>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
matthias-springer
force-pushed
the
users/matthias-springer/failed_leg_new_error
branch
from
8f7faa2 to
73dfec2
Compare
matthias-springer
deleted the
users/matthias-springer/failed_leg_new_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a more detailed error message when new/modified IR could not be legalized with
allowPatternRollback = false. This is useful to understand why a pattern is incompatible with the new One-Shot Dialect Conversion driver.